Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] 9.8.0 bug report #148

Closed
SondreElg opened this issue Apr 25, 2023 · 6 comments · Fixed by #151
Closed

[Bug] 9.8.0 bug report #148

SondreElg opened this issue Apr 25, 2023 · 6 comments · Fixed by #151

Comments

@SondreElg
Copy link
Contributor

SondreElg commented Apr 25, 2023

Seems like merge conflicts caused a lot of problems for this release

Max HP damage

Cannot input m into HP field, so functionality can't be tested
Token was missing in HP field input validation

Temp AC change

Can input into field, but there is no change to AC
AC argument was missing in call to tracker.doUpdate()

Status field

Attempting to apply a custom status adds "undefined" to the status list.
If an even number of custom statuses are added, they are applied then instantly relieved when finalizing the operation.

@valentine195
Copy link
Member

@SondreElg hey I'm pushing a fix, but I can't recreate the status error

@valentine195
Copy link
Member

It was a bit of a mess trying to clean up those two PRs because I left them open so long, my bad!

@valentine195
Copy link
Member

can you test 9.8.1 please

@SondreElg
Copy link
Contributor Author

Same bug appears in 9.8.1

- Start an encounter
- Add "a" (or any other non-existing status) as status
= "undefined" is added to status list
- Apply
= "undefined" status is added
= Log shows "Name took status"

- Repeat but add an even number of statuses
= No status is added
= Log shows "Name took status" "Name relieved of status undefined"

@valentine195
Copy link
Member

Oh I see - I thought by custom you meant one defined in settings

@SondreElg
Copy link
Contributor Author

I can see where the confusion stems from.
Perhaps "improvised status" is a better term for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants