Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic unconscious status is not logged properly #132

Closed
dfaggioli opened this issue Apr 21, 2023 · 0 comments · Fixed by #133 or #138
Closed

Automatic unconscious status is not logged properly #132

dfaggioli opened this issue Apr 21, 2023 · 0 comments · Fixed by #133 or #138

Comments

@dfaggioli
Copy link
Contributor

If "Automatic Unconscious Status Application" is enabled, a creature gains the "Unconscious" status as soon as it reaches 0 HP. Such event is, however, not recorded in the combat log (unless the creature takes more damage).

For instance, when a creature with 135 HP suffers 156 damage, I only see Aboleth took 156 damage., despite the "Unconscious" status is being properly applied and shown in the tracker.

If the creature takes, say, 23 more damage, then I see this: Aboleth took 23 damage and was knocked unconscious..

I think this is because when the following check is done:

                        if (creature.hp) {
                            message.unc = true;
                        }

in updatingCreatures, the HPs are greater than 0, as the damage has not been applied yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants