Update api.ts #367
Open
Update api.ts #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated narrative case in API to handle conflict with onload & FS rendering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated narrative case in API to handle conflict with onload & FS rendering.
Pull Request Description
Re: discord troubleshooting, narrative roller unable to produce a result because children are populated in the onload step, which is cleared(?) when a FS statblock renders. Re-triggering the onload script solves this, though I'm not sure it's best practice. Likely would be better to move the children population to its own function and call it at the appropriate time.
Changes Proposed
Minor changes to the narrative case in API.ts.