Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Fixing jaxr-ra pom.xml files #22535

Merged
merged 6 commits into from
Jul 9, 2018
Merged

Fixing jaxr-ra pom.xml files #22535

merged 6 commits into from
Jul 9, 2018

Conversation

ankathur
Copy link
Member

Fixing #22531

@ankathur
Copy link
Member Author

@glassfishrobot Run CI tests please

@ankathur
Copy link
Member Author

@glassfishrobot run ci tests please

@glassfishrobot
Copy link
Contributor

Starting CI tests run

@glassfishrobot
Copy link
Contributor

One or more CI tests failed

@ankathur
Copy link
Member Author

@glassfishrobot run ci tests please

@glassfishrobot
Copy link
Contributor

Starting CI tests run

@glassfishrobot
Copy link
Contributor

All CI tests successful

romain-grecourt
romain-grecourt reviewed Jun 22, 2018
View reviewed changes
appserver/pom.xml Outdated
<jboss.classfilewriter.version>1.2.1.Final</jboss.classfilewriter.version>
<easymock.version>3.5</easymock.version>
<javax.resource-api.version>1.7.1</javax.resource-api.version>
<javax.xml.registry-api.version>1.0.8</javax.xml.registry-api.version>
<maven-rar-plugin.version>2.4</maven-rar-plugin.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this property used ? I don't see a plugin definition for maven-rar-plugin.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maven-rar-plugin is defined in appserver/jaxr-ra/jaxr-ra-rar/pom.xml.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you instead add pluginManagement in appserver/pom.xml and omit the version under appserver/jaxr-ra/jaxr-ra-rar/pom.xml.

@ankathur ankathur requested a review from yaminikb June 25, 2018 04:58
romain-grecourt
romain-grecourt previously approved these changes Jul 6, 2018
View reviewed changes
Copy link
Member

@romain-grecourt romain-grecourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ankathur
Copy link
Member Author

ankathur commented Jul 9, 2018

@glassfishrobot run ci tests please

@glassfishrobot
Copy link
Contributor

Starting CI tests run

@glassfishrobot
Copy link
Contributor

All CI tests successful

@ankathur
Copy link
Member Author

ankathur commented Jul 9, 2018

@glassfishrobot run ci tests please

@glassfishrobot
Copy link
Contributor

Starting CI tests run

@glassfishrobot
Copy link
Contributor

All CI tests successful

@yaminikb yaminikb merged commit b33c5cc into javaee:master Jul 9, 2018
@glassfishrobot glassfishrobot mentioned this pull request Sep 17, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yaminikb yaminikb yaminikb approved these changes

@romain-grecourt romain-grecourt romain-grecourt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ankathur @glassfishrobot @romain-grecourt @yaminikb