Some error handling in get serial port names #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks as there's some error handling missing here. Unluckily I do NOT have any windows box available right now. And I'm far from having a jssc build environment ready. So I'll try my best to write this code with nothing more than the msdn documentation and a plain text editor. Lets see how many compiler errors I'll produce. Related: - java-native jssc issue 170
tresf
reviewed
Aug 10, 2024
|
LGTM, but I haven't tested the code and it's not my area of expertise, so a second review is recommended prior to merging. |
tresf
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks as there's some error handling missing here. Unluckily I do NOT have any windows box available right now. And I'm far from having a jssc build environment ready. So I'll try my best to write this code with nothing more than the msdn documentation and a good old text editor. Lets see how many compiler errors I'll produce.
Maybe somebody can have a look if this helps with #170?
maybe fixes: #170
Edit: Oh cool :) jssc got gh actions. Thanks for setting this up.