Skip to content

add 'milliseconds' to duration javadoc #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2022
Merged

Conversation

aSemy
Copy link

@aSemy aSemy commented Sep 25, 2021

I haven't checked if it is actually milliseconds! See #73 for more info.

Resolve #73

TODO

  • confirm that duration is in milliseconds

@tresf
Copy link

tresf commented Jan 9, 2022

#73

The unix source code calls a second "duration / 1000", then converts to nanoseconds calling nanosleep.

int sec = (duration >= 1000 ? duration/1000 : 0);

The windows source code calls Sleep(), which is nanoseconds.

Confirmed. :)

@tresf tresf merged commit 6886b44 into java-native:master Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Javadocs for sendBreak() should indicate units for duration value
2 participants