-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add WlanApi module #1697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WlanApi module #1697
Conversation
matthiasblaesing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I made a first pass. Please have a look at the inline comments.
matthiasblaesing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. I checked the type definitions against MSDN and the headers are a bit convoluted. I see:
-
Definitions from
Wlantypes.h(or Windot11.h, see blow):DOT11_SSID_MAX_LENGTHDOT11_AUTH_ALGORITHMDOT11_CIPHER_ALGORITHMDOT11_BSS_TYPE(it is defined in Wlantypes.h, MSDN says you should includewindot11.h...)DOT11_SSID(it is defined in Wlantypes.h, MSDN says you should includewindot11.h...)
-
Definitions from
Windot11.h:DOT11_MAC_ADDRESSDOT11_PHY_TYPE
I think moving the referenced types to Windot11.java might be the cleanest solution.
For the type mapping of WLAN_SECURITY_ATTRIBUTES, please ensure, that a correct typemapper is active. boolean is not well defined. In Windows it is BOOL (32bit), but people would like to have boolean be a C bool, which is one byte (commonly). Use the com.sun.jna.win32.W32APITypeMapper.UNICODE mapper.
I moved all of these to
I used |
matthiasblaesing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience. There are two inline changes required.
After that please squash all changes into a single commit and add an entry to CHANGES.md in the Features section. Have a look at the other entries for the format and template for the changes.
| @@ -0,0 +1,109 @@ | |||
| /* Copyright (c) 2010 Daniel Doubrovkine, All Rights Reserved | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| /* Copyright (c) 2010 Daniel Doubrovkine, All Rights Reserved | |
| /* Copyright (c) 2025 Eran Leshem, All Rights Reserved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
| @@ -0,0 +1,234 @@ | |||
| /* Copyright (c) 2010 Daniel Doubrovkine, All Rights Reserved | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| /* Copyright (c) 2010 Daniel Doubrovkine, All Rights Reserved | |
| /* Copyright (c) 2025 Eran Leshem, All Rights Reserved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Done. I'm curious: why not do this while merging to
Done. |
Because github squash-on-merge is broken. The NetBeans project tried it and github multiple times generated broken commits. Github replaces the author information in the resulting commit with different information, than the one of the individual commits. git rebase takes the author information from the commits, github tries to be clever and use the users "public" data. Multiple times we lost realnames and/or emails because users had strange privacy settings for their github account. |
89ea87e
into
java-native-access:master
This is a partial mapping of
WlanApi.h.