Default highlights attributes #259
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on feedback from the mobile team, updated the default highlights configuration for mobile platforms to show more relevant information: Added tags: - device.class - release - user Added context keys: - device: low_memory, locale - app: in_foreground - user: geo.country_code Removed less useful context: - trace.trace_id (redundant with trace preview) - profile.profile_id (almost always empty) - mobile tag (not very informative) This change affects Android, Apple (iOS/macOS), React Native, and other mobile platforms. Refs: ID-1344 Co-authored-by: Charlie Luo <cvxluo@gmail.com>
|
🚨 2 CI Failures
|
|
It also removes the previous generic Affected Areas• This summary was automatically generated by @propel-code-bot |
![propel-test-bot[bot]](https://avatars.githubusercontent.com/in/1229011?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found; the updated mobile highlights preset and accompanying test look sound and align with the stated goals.
Status: No Issues Found | Risk: Low
Review Details
📁 2 files reviewed | 💬 0 comments
Instruction Files
├── .cursor/
│ └── rules/
│ ├── README.md
│ ├── backend.mdc
│ ├── frontend.mdc
│ ├── general.mdc
│ └── tests.mdc
├── AGENTS.md
├── CLAUDE.md
├── src/
│ ├── AGENTS.md
│ └── CLAUDE.md
└── tests/
├── AGENTS.md
└── CLAUDE.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Linear ID-1344 by improving the default highlights section for mobile SDK issues.
Based on feedback from the mobile team, the highlights were previously sparse and lacked actionable debugging information. This change updates the
MOBILE_HIGHLIGHTSpreset to include more relevant tags and context keys, such asdevice.class,release,main_thread,user,low_memory,in_foreground,locale, anduser.geo.country_code. Less useful items liketrace.trace_idandprofile.profile_idhave been removed.A new test has been added to ensure the mobile highlight preset is correctly applied.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Linear Issue: ID-1344
Copied from getsentry#107904
Original PR: getsentry#107904