Update to Aspire 13.4 - #1635
Open
maddymontaquila wants to merge 2 commits into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Owner
|
@copilot resolve the merge conflicts in this pull request |
There was a problem hiding this comment.
🟡 Changes recommended
A remaining patch-level mismatch in centrally managed .NET 10 package versions should be resolved (or explicitly justified) to avoid inconsistent dependency graphs.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates this CleanArchitecture template to the latest Aspire 13.4 toolchain and aligns supporting docs/config with current Aspire CLI conventions, while also bringing several .NET 10 package references forward.
Changes:
- Bump Aspire AppHost SDK and related Aspire packages to 13.4.6 (and update several .NET 10 packages to newer patch versions).
- Replace legacy
.aspire/settings.jsonwith root-levelaspire.config.jsonfor Aspire CLI/AppHost discovery. - Update repository and template README run instructions to recommend
aspire run(keepingdotnet runas an alternative) and remove remaining “.NET Aspire” branding.
File summaries
| File | Description |
|---|---|
| tests/TestAppHost/TestAppHost.csproj | Updates AppHost SDK version to Aspire 13.4.6 for test host. |
| src/ServiceDefaults/Extensions.cs | Updates header comment to remove “.NET Aspire” branding. |
| src/AppHost/AppHost.csproj | Updates AppHost SDK version to Aspire 13.4.6. |
| README.md | Adds recommended aspire run instructions alongside dotnet run. |
| README-template.md | Adds recommended aspire run instructions to generated project README. |
| Directory.Packages.props | Updates central package versions for Aspire and .NET 10 dependencies. |
| aspire.config.json | Adds new root-level Aspire CLI config pointing to AppHost project. |
| .aspire/settings.json | Removes legacy Aspire settings file. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Absolutetly love this template Jason!!! Thought I'd send some updates on the aspire side! TY!
Summary
.aspire/settings.jsonwith the current root-levelaspire.config.jsonaspire runin both repository and generated-project documentation while retaining the .NET CLI optionValidation
dotnet build CleanArchitecture.slnx --nologoaspire start, waited forwebapito become healthy, and stopped it cleanly