Fix _default_px function.#8
Open
jdfreder wants to merge 1 commit intojasongrout:custom-serializationfrom
Open
Conversation
Owner
|
When would value be a number? I thought all of the traits were unicode. Also, even if we have a number, shouldn't we convert it to a string and append 'px'? |
Author
|
I'm not sure when it is a number, but that's and other non-(string|null|undefined) values are the only failing case I noticed. Maybe one/more of the widgets are using default_px on non-unicode traits when they shouldn't be. I pass numbers through, allowing jQuery to decided what the default unit should be. When we ween the widgets from jQuery, we may want to make this explicit by returning |
eef3dc4 to
f53208d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.