fix replacing all "%20" with "+" in $.param()

jasondscott · Sep 23, 2012 · 3c11adf · 3c11adf
1 parent ee77d69
commit 3c11adf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/ajax.js b/src/ajax.js
@@ -276,6 +276,6 @@
     var params = []
     params.add = function(k, v){ this.push(escape(k) + '=' + escape(v)) }
     serialize(params, obj, traditional)
-    return params.join('&').replace('%20', '+')
+    return params.join('&').replace(/%20/g, '+')
   }
 })(Zepto)
diff --git a/test/ajax.html b/test/ajax.html
@@ -664,6 +664,11 @@ <h1>Zepto Ajax unit tests</h1>
         t.assertEqual("equation%5B1%5D=bananas%2Bpeaches%3Dsmoothie", result)
       },
 
+      testParamSpaces: function(t) {
+        var result = $.param({ "foo bar": "baz kuux" })
+        t.assertEqual("foo+bar=baz+kuux", result)
+      },
+
       testParamComplex: function(t) {
         var data = {
           a: ['b', 'c', { d:'e', f:['g','h'] }]