Update configuration for image generation settings #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the configuration and API routes to add support for image generation settings and documents these changes.
- Update TinyLLM version and reorder configuration variables.
- Add new environment variables for image generation settings in the configuration file and update the ImageGenerator instantiation accordingly.
- Update release notes to reflect the new settings.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| chatbot/app/core/config.py | Reordered configuration variables and added image generation settings. |
| chatbot/app/api/routes.py | Updated function calls and ImageGenerator instantiation to use new image settings. |
| RELEASE.md | Updated release notes to include information about image generation settings. |
RELEASE.md
Outdated
Comment on lines
9
to
10
| * Flux/flux1-schnell-fp8 - use `IMAGE_CFGSCALE=1` and `IMAGE_STEPS=4` | ||
| * Flux/flux1-schnell-fp8 - use `IMAGE_CFGSCALE=1` and `IMAGE_STEPS=20` |
There was a problem hiding this comment.
[nitpick] There are two different suggestions for the Flux/flux1-schnell-fp8 model with conflicting image step values. Please verify and clarify the intended configuration to avoid confusion.
Suggested change
| * Flux/flux1-schnell-fp8 - use `IMAGE_CFGSCALE=1` and `IMAGE_STEPS=4` | |
| * Flux/flux1-schnell-fp8 - use `IMAGE_CFGSCALE=1` and `IMAGE_STEPS=20` | |
| * Flux/flux1-schnell-fp8 - use `IMAGE_CFGSCALE=1` and `IMAGE_STEPS=4` for quick previews or low-detail outputs. | |
| * Flux/flux1-schnell-fp8 - use `IMAGE_CFGSCALE=1` and `IMAGE_STEPS=20` for high-quality or detailed outputs. |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Good catch - the second one should be the dev version instead of schnell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.16.1 - Image Generation Settings
Added environment variables for image generation settings:
IMAGE_MODEL,IMAGE_CFGSCALE,IMAGE_STEPS,IMAGE_SEED,IMAGE_TIMEOUT,IMAGE_WIDTH, andIMAGE_HEIGHT.Some suggestions based on models (see https://github.com/mcmonkeyprojects/SwarmUI/blob/master/docs/Model%20Support.md for more):
IMAGE_CFGSCALE=20andIMAGE_STEPS=20IMAGE_CFGSCALE=1andIMAGE_STEPS=4IMAGE_CFGSCALE=1andIMAGE_STEPS=20