Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anonymous access prompt during setup #583

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mccahan
Copy link

@mccahan mccahan commented Feb 15, 2025

I saw settings for allowing anonymous access in the Grafana env sample, but figured it might be helpful to surface it as a question during the setup process.

image

@jasonacox
Copy link
Owner

Thanks @mccahan - I like the idea. However, if we make this a separate workflow (anonymous-access.sh) it gives the impression that it is a standalone script. I think that is what we want, but currently the script pays no attention to the existing grafana.env file. Additionally, the way that the conditional works in setup.sh, it means that it will only run the first time you install. Ideally we want people to be able to run setup.sh to modify their configuration.

Can we add logic to edit the grafana.env instead of just append? I think it could be as simple as sed removing the relevant lines and then appending them back, as you have now.

@mccahan
Copy link
Author

mccahan commented Feb 16, 2025

@jasonacox good thoughts

  • Made it run every time they run setup.sh
  • Removes config lines (and double-checks the built-ins are commented out as appropriate) before appending when they change modes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants