Modifying jasmin2tex integer representation to fit source integer representation better #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add new Syntax Node `pbasedinteger` which dissapear at pretyping * Changing parser and lexer accordingly * Changing latex_printer integer handling
vbgl
reviewed
Sep 3, 2024
compiler/src/lexer.mll
Outdated
Comment on lines
138
to
142
| { INT {zvalue=Z.of_string s;raw=s}} | ||
|
|
||
| | ('0' ['x' 'X'] hexdigit+) as s | ||
| { INT (Z.of_string s) } | ||
| { INT {zvalue=Z.of_string s;raw=s} } | ||
|
|
There was a problem hiding this comment.
Why do you compute the Z value here? Isn’t it simpler to only keep the string here and compute the value in pre-typing?
There was a problem hiding this comment.
I wasn't very used to the process of the compiler so I wanted the modification to affect the smallest possible part of the code. If you think it is preferable that the Z type building is done in pre-typing, I can change it (it will indeed simplify code readability)
* type pbaseinteger deleted (not usefull anymore) * converting is done in pre-typing
vbgl
reviewed
Sep 5, 2024
vbgl
reviewed
Sep 5, 2024
Co-authored-by: Vincent Laporte <vbgl@users.noreply.github.com>
vbgl
previously approved these changes
Sep 6, 2024
vbgl
approved these changes
Sep 6, 2024
vbgl
pushed a commit
that referenced
this pull request
Sep 6, 2024
(cherry picked from commit faf9b1d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
jasmin2tex program always convert integer from source file to base 10. In certain cases, it makes readability of the program harder. For example :
is converted to :
Solution
We implement a new Syntax node
pbintegerthat store the raw integer string coming from source file :At pretyping, we convert this type back to
Z.t, which mean that it does not affect the behavior of the compiler for all next compilation steps. Sincelatex_printeris executed before pre-typing, we can use the raw string for generating latex file. The new output is now :Changelog
pbasedintegerwhich dissapear at pretyping