Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretyping: accept all calls to export functions #731

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

vbgl
Copy link
Member

@vbgl vbgl commented Feb 15, 2024

Just emit a warning if said call is not annotated as inline

Fixes #729

@bgregoir
Copy link
Contributor

Not a big fan of than, I will prefers a solution where we did not fail, if the #inline is added at call cite but doit it silently ...

Copy link
Contributor

@bgregoir bgregoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missing the fact that a warning is now printed. Forgot my last comment.

Just emit a warning if said call is not annotated as inline
@bgregoir bgregoir merged commit 6ae8ab1 into main Feb 16, 2024
@bgregoir bgregoir deleted the auto-inline-call-to-export branch February 16, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-inline call to export function should be a simple warning
2 participants