Arm large stack #677
Merged
Arm large stack #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarranz
reviewed
Jan 8, 2024
compiler/src/arm_arch_full.ml
Outdated
| @@ -26,6 +26,9 @@ module Arm_core = struct | |||
|
|
|||
| let known_implicits = ["NF", "_nf_"; "ZF", "_zf_"; "CF", "_cf_"; "VF", "_vf_"] | |||
|
|
|||
| let alloc_stack_need_extra sz = | |||
| not (Arm_decl.is_expandable (Conv.cz_of_z sz)) | |||
There was a problem hiding this comment.
If this check corresponds to whether we can allocate/free stack with SUB sp, sp, #imm and ADD sp, sp, #imm, we can also allow 12-bit immediates. We should have is_expandable || is_w12_encoding (this corresponds to encodings T3 and T4 from the manual, e.g. A7.7.5 for ADD).
There was a problem hiding this comment.
I now use is_arith_small
sarranz
reviewed
Jan 8, 2024
proofs/compiler/arm_params.v
Outdated
| @@ -79,12 +79,18 @@ Section LINEARIZATION. | |||
| Notation vtmpi := (mk_var_i (to_var R12)). | |||
|
|
|||
| (* TODO_ARM: This assumes 0 <= sz < 4096. *) | |||
There was a problem hiding this comment.
I have remove the comment.
sarranz
reviewed
Jan 8, 2024
proofs/compiler/arm_params.v
Outdated
| if tmp is Some aux then | ||
| arm_cmd_large_subi_tmp rspi aux sz | ||
| else | ||
| [:: arm_op_subi rspi rspi sz]. | ||
|
|
||
| (* TODO_ARM: This assumes 0 <= sz < 4096. *) |
There was a problem hiding this comment.
Sorry, what do you means here ? What is not longer true ?
bgregoir
force-pushed
the
arm-large-stack
branch
2 times, most recently
from
fec6d2c to
190eeee
Compare
vbgl
force-pushed
the
arm-large-stack
branch
2 times, most recently
from
77007ea to
00731a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the generate code for arm when stack is large.