Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize arm_cmd_large_arith_imm #597

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Optimize arm_cmd_large_arith_imm #597

merged 1 commit into from
Oct 4, 2023

Conversation

sarranz
Copy link
Collaborator

@sarranz sarranz commented Oct 2, 2023 •
edited
Loading

Now $ ./jasminc -arch arm-m4 tests/success/arm-m4/memcmp.jazz -pasm gives

memcmp:
	push	{lr}
	SUB 	r12, sp, #8

instead of

memcmp:
	push	{lr}
	MOV 	r12, #8
	MOVT	r12, #0
	SUB 	r12, sp, r12

Closes #379.

@sarranz sarranz marked this pull request as draft October 2, 2023 23:31
@vbgl vbgl added the arm Related to the arm port label Oct 3, 2023
@sarranz sarranz force-pushed the arm-load-large-imm branch from cf13497 to c85de81 Compare October 3, 2023 14:18
@sarranz sarranz marked this pull request as ready for review October 3, 2023 14:18
@sarranz sarranz force-pushed the arm-load-large-imm branch from c85de81 to 5a11328 Compare October 3, 2023 14:22
vbgl
vbgl approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@vbgl vbgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this deserve a few words in the changelog?

@sarranz
Copy link
Collaborator Author

sarranz commented Oct 3, 2023

Does this deserve a few words in the changelog?

Sure, give me a minute

@sarranz sarranz force-pushed the arm-load-large-imm branch from 5a11328 to c3c1fb7 Compare October 3, 2023 19:11
@vbgl
Copy link
Member

vbgl commented Oct 4, 2023

Thanks.

@vbgl vbgl merged commit 02dffce into main Oct 4, 2023
@vbgl vbgl deleted the arm-load-large-imm branch October 4, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl approved these changes

Assignees
No one assigned
Labels
arm Related to the arm port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize arm_cmd_large_arith_imm
2 participants
@sarranz @vbgl