Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checksafety: reset A/M-var conversion table #315

Merged
merged 1 commit into from
Jan 10, 2023
Merged

checksafety: reset A/M-var conversion table #315

merged 1 commit into from
Jan 10, 2023

Conversation

vbgl
Copy link
Member

@vbgl vbgl commented Dec 13, 2022

Fixes #314

@vbgl vbgl force-pushed the safety-vars-reset branch 2 times, most recently from 59c3a6d to 17878ef Compare January 4, 2023 12:37
@vbgl
Copy link
Member Author

vbgl commented Jan 4, 2023

Just rebased to fix merge conflicts; CI is happy: https://gitlab.com/jasmin-lang/jasmin/-/pipelines/738010398

@eponier
Copy link
Contributor

eponier commented Jan 4, 2023

Is this an easy hack or the proper way to fix this problem?

@vbgl
Copy link
Member Author

vbgl commented Jan 4, 2023

Ideally it would be better to get rid of mutable global variables.

eponier
eponier approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@eponier eponier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough.

@eponier
Copy link
Contributor

eponier commented Jan 10, 2023

I've just launched another CI. I'll merge when this is green.

@eponier
Copy link
Contributor

eponier commented Jan 10, 2023

Green (https://gitlab.com/jasmin-lang/jasmin/-/pipelines/742827214)!

@eponier eponier merged commit ccc9b66 into main Jan 10, 2023
@eponier eponier deleted the safety-vars-reset branch January 10, 2023 10:09
@vbgl
Copy link
Member Author

vbgl commented Jan 10, 2023

Merci! One little step closer to be able to check libjade!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eponier eponier eponier approved these changes

Assignees
No one assigned
Labels
bug safety-checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checksafety crash: Failure("Environment.make: duplicated variable names")
2 participants
@vbgl @eponier