Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x86: remove support for explicit if-then-else in flag combinations #270

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

vbgl
Copy link
Member

@vbgl vbgl commented Oct 13, 2022

A comment says this should be removed…

Does this need an entry in the CHANGELOG?

@eponier
Copy link
Contributor

eponier commented Oct 17, 2022

Does it change anything for users?

cc @bgregoir who wrote that comment (commit 33d6b62)

@vbgl
Copy link
Member Author

vbgl commented Oct 17, 2022

This can break legacy code (if the programmer explicitly wrote something like: x = y if (sf ? !of : of), which can easily be written as x = y if sf != of, up to typo).

My belief is that no such legacy code exist.

@eponier
Copy link
Contributor

eponier commented Oct 17, 2022

Ok, but it is preferable to have something written down in the changelog then, I think. The explanation can be short.

@vbgl
Copy link
Member Author

vbgl commented Oct 18, 2022

I’ve just added a line into the changelog.

Copy link
Contributor

@eponier eponier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changelog message!

@eponier eponier merged commit 3aa0d35 into main Oct 18, 2022
@eponier eponier deleted the asmgen-remove-specialcase branch October 18, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants