Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 202 #229

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Fix 202 #229

merged 1 commit into from
Sep 2, 2022

Conversation

vbgl
Copy link
Member

@vbgl vbgl commented Sep 1, 2022

No description provided.

@vbgl vbgl mentioned this pull request Sep 1, 2022
Closed
bgregoir
bgregoir reviewed Sep 1, 2022
View reviewed changes
Copy link
Contributor

@bgregoir bgregoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The case for Copn does not need to be changed to ?

@vbgl
Copy link
Member Author

vbgl commented Sep 1, 2022

I think the case of Copn is right: auxiliary variables are used only for the outputs, which is consistent with what init_aux_i does.

@bgregoir bgregoir merged commit b848009 into main Sep 2, 2022
@bgregoir bgregoir deleted the fix-202 branch September 2, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgregoir bgregoir bgregoir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbgl @bgregoir