Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register allocation overlooks conflicts between flag registers #309

Closed
vbgl opened this issue Dec 12, 2022 · 0 comments · Fixed by #311
Closed

Register allocation overlooks conflicts between flag registers #309

vbgl opened this issue Dec 12, 2022 · 0 comments · Fixed by #311

Comments

@vbgl
Copy link
Member

vbgl commented Dec 12, 2022

When compiling the following program, register allocation succeeds and happily allocates the cf variable to the CF register. Compilation later crashes with the unhelpful “variable already set”.

export
fn test(reg u64 x) -> reg u64 {
  reg u64 r;
  reg bool cf;
  cf, x = x + x;
  r = #set0();
  r = x if cf;
  return r;
}

This is a regression of the glob-array3 branch, introduced by commit d316054.

@vbgl vbgl self-assigned this Dec 12, 2022
vbgl added a commit that referenced this issue Dec 12, 2022
vbgl added a commit that referenced this issue Dec 12, 2022
vbgl added a commit that referenced this issue Dec 12, 2022
vbgl added a commit that referenced this issue Dec 12, 2022
bgregoir pushed a commit that referenced this issue Jan 4, 2023
vbgl added a commit that referenced this issue Jan 8, 2023
Fixes #309

(cherry picked from commit 7e853e1)
vbgl added a commit that referenced this issue Jan 8, 2023
Fixes #309

(cherry picked from commit 7e853e1)
(cherry picked from commit 7ef028c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant