Fix escaped chars in Javascript in templates

[Stuk]

If an escaped character (e.g. \n) is used in embedded Javascript inside a template then it gets escaped to \n. If someone has put an escaped character in their JS then they probably want it left that way.

This merge request adds a test for this, and the following commit replaces \s with a single \ when inside evaluation tags, reverting the previous template escaping.

[jashkenas]

This doesn't look right. For starters, you're simply converting two slashes \\ into one \ . This will affect many other things than just newlines.

In addition, you're putting an extra slash in the "replace" function in your test -- so I'm not sure what the test is trying to accomplish.

[Stuk]

In the test it would be incorrect to have just \n, as that would be invalid JS

numbers.split("
")

and so the \n needs to be escaped there (if the template was being loaded from a <script> tag then you would just have the \n).

The fix is just undoing the replacement from line 902. I think that if someone puts a \ inside <% %> tags they would want it left alone. I might be wrong of course :)

[jashkenas]

Sure ... but this is valid JS:

numbers.split("\n")

[Stuk]

Not when it's JS inside another string :)

[jashkenas]

-- then that's your problem ;) Don't put JS in strings.

[Stuk]

I'm back again, with an example that (hopefully) definitely shows the problem: http://stuartk.com/files/underscore_example.html

[jashkenas]

Thanks for being persistent ;)

[Stuk]

No problem :)