-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Prepare 1.12.0 #2878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 1.12.0 #2878
Conversation
Regarding the failing build: that's SauceLabs failing to spin up outdated browsers again. I'll create an issue for that. The tests all pass, as you can see by scrolling upwards from this line. |
Hold on, I started fiddling with the Sauce labs tests and then found out that there are still some minor compatibility issues with |
Alright, fixed some more bugs and compatibility issues, kicked up some performance and finally got the Sauce tests to run smoothly most of the time. Really ready for review now. (Travis ran twice because this is both a PR and a branch on the main repo. The second build failed because Coveralls can't handle checking the same commit twice. I'll avoid this situation in the future by only issueing PRs from my fork.) |
The main reason for issuing a release now is the bugfix in #2876, but I'm bumping the minor version number rather than the patch number, because the new feature from #2877 already slipped into
master
before that. I'm not planning to draw special attention to the latter at this time, because the corresponding update to Contrib hasn't happened yet.@jashkenas I have already updated all the generated files. Only the following steps remain for you, once you've approved this PR (edit: the only interesting part of the diff is the index.html, which contains the new change log entry and a new section about engine compatibility):
TODO
inline comment on lines 2656-2658 of theindex.html
by the date of release.prepare-1.12.0
intomaster
.npm publish
: this will re-generate the bundles and annotated sources again, but should leave your working tree in a clean state. You'll get that warning again about mixing named and default exports, possibly twice, which you can still ignore. It will disappear in version 2.0.master
intogh-pages
.@sktguha This update will not include your planned optimization of
_.isEqual
yet, but rest assured that your contribution is still welcome.@joshuacc FYI:
_.toPath
will be in this release.