Be even more explicit about the semantics of _.isEmpty #2840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is meant to address jashkenas#2804.
jashkenas
reviewed
Apr 10, 2020
Collaborator
Author
|
Thanks @jashkenas. As I understand it, you are fine with the current change (given that I have removed the counter-example that you rightly pointed out). So if @mcurrao requests no further changes, I'll not request another review from you before merging this. |
|
@jgonggrijp LGTM. Only missing elements would be functions, but as they can be considered non-enumerable objects, I guess there is no need to include them. Thanks! |
jashkenas
approved these changes
Apr 10, 2020
Collaborator
Author
|
Sorry, requesting another review anyway because I just noticed a tautology in the code and removed it. |
jashkenas
approved these changes
Apr 13, 2020
This reverts commit 0252976 and addresses the review comment below: jashkenas#2840 (comment)
This was referenced Apr 14, 2020
jgonggrijp
added a commit
to jgonggrijp/underscore
that referenced
this pull request
Aug 1, 2020
jgonggrijp
added a commit
to jgonggrijp/underscore
that referenced
this pull request
Oct 24, 2020
After optimizing the internal tagTester function, I decided to re- evaluate the optimization and benchmark discussed from jashkenas#2840 (comment) onwards. Now that tagTester is faster, the tradeoff posed by this optimization had become less obviously in favor. Especially evaluating the length of strings appeared to be relatively costly. I realized this was happening twice, so I removed the redundant evaluation. This could be done at a net zero weight change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to address #2804.
@mcurrao Please let me know whether this sufficiently addresses the problem for you.