Skip to content

Set and Map support for _.isEmpty #2808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ushakov-igor wants to merge 1 commit into from
Closed

Set and Map support for _.isEmpty #2808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion underscore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1297,11 +1297,12 @@
return eq(a, b);
};

// Is a given array, string, or object empty?
// Is a given array, string, set, map or object empty?
// An "empty" object has no enumerable own-properties.
_.isEmpty = function(obj) {
if (obj == null) return true;
if (isArrayLike(obj) && (_.isArray(obj) || _.isString(obj) || _.isArguments(obj))) return obj.length === 0;
if (toString.call(obj) == '[object Map]' || toString.call(obj) == '[object Set]') return !obj.size
return _.keys(obj).length === 0;
};

Expand Down