Add _.keysIn method #1910
Merged
Add _.keysIn method #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| 'toLocaleString': undefined, | ||
| 'propertyIsEnumerable': /a/, | ||
| 'isPrototypeOf': this, | ||
| '__defineGetter__': Boolean, |
There was a problem hiding this comment.
Legacy getter/setter properties are out of scope.
|
Rebased and squashed |
jamiebuilds
force-pushed
the
keysIn
branch
2 times, most recently
from
57dfed7 to
ab2d026
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From this thread.
_.keysInis the alternate to_.keysnot just limited to own-properties, which can be useful internally and externally so people can create their own mixins.I only targeted the most common cases I could think of here. Hopefully @jdalton can shine some light on all the different edge cases Lodash's
_.keysIncovers.