Remove unnecessary variable declaration. #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah this feels more consistent with the rest of the codebase. I like this style a bit more. |
|
I prefer this PR's style too. I used to be "hoist all the vars" but over time found it more beneficial to var-up on first use. When I hoisted I tended to initialize values, however many times that meant doing the leg work for vars that weren't used in a given fork. |
|
This is how it used to be ... but things sneak in over time... |
jashkenas
added a commit
that referenced
this pull request
Jun 16, 2014
Remove unnecessary variable declaration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the two styles are functionally equivalent, I find it easier to distinguish local variables from arguments when they're declared the first time they're assigned to. Thoughts?