uniqueId function is whitespace-dependent in minified script

[hughes]

The unminified uniqueId function contains:

var id = '' + (++idCounter);

This minifies to:

var t=""+ ++N;

It works as it is, but breaks if the spacing changes:

var t=""+++N; // error

I know, you're thinking "why would you change the spacing if it works as it is?" I noticed this issue because we bundle underscore-min.js in our site's aggregated javascript file, the generator of which strips whitespace.

I know our bundling script is not optimal if it's breaking stuff, but this is the only part of underscore-min.js that suffers because of it.

If the function read var id = (++idCounter) + ''; it would not suffer from this issue.

[caseywebdev]

👍 Not for the sake of a broken minifier, but because it's easier to read var id = ++idCounter + ''