Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch is a dev dependency in 1.13.5. #2969

Closed
markfoo1 opened this issue Sep 23, 2022 · 3 comments
Closed

Patch is a dev dependency in 1.13.5. #2969

markfoo1 opened this issue Sep 23, 2022 · 3 comments
Labels
duplicate

Comments

@markfoo1
Copy link

Consumers who use underscore as a dependency rather than as a dev dependency fail in postinstall because patch package is not available.
@mjaggard
Copy link

This has broken my build :(

@acrobertson acrobertson mentioned this issue Sep 23, 2022
Open
@iglosiggio iglosiggio mentioned this issue Sep 23, 2022
Closed
@joeycozza
Copy link

duplicate of #2967

@paulsmithkc paulsmithkc mentioned this issue Sep 23, 2022
Merged
@jgonggrijp
Copy link
Collaborator

I just released 1.13.6, hopefully that fixes it. Please close if that is the case.

jgonggrijp added a commit that referenced this issue Sep 23, 2022
@jgonggrijp
Remove patch-package postinstall script
1c1d1a2 
This broke much more stuff than I expected.

Ref #2967 #2968 #2969 #2970 #2971 #2972 #2973 #2974
jgonggrijp added a commit to jgonggrijp/underscore that referenced this issue Sep 23, 2022
@jgonggrijp
Run patch-package when building the docs
60835dc 
Ref jashkenas#2967 jashkenas#2968 jashkenas#2969 jashkenas#2970 jashkenas#2971 jashkenas#2972 jashkenas#2973 jashkenas#2974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mjaggard @jgonggrijp @joeycozza @markfoo1