[CS2] Fix CS2 build after merge pulled in a bare super call #4447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like super calls need to explicitly specify their args now, so I added the arg in `Call.prototype.updateLocationDataIfMissing`. Also, the JS code hadn't updated, I guess due to the build failure, so re-run `bin/cake build` so `lexer.js` and `nodes.js` both get updated. This fixes the tests.
GeoffreyBooth
changed the title
Collaborator
|
Thanks! P.S. You might find this of interest: https://rawgit.com/jashkenas/coffeescript/2/docs/v2/index.html#breaking-changes |
Contributor
Author
|
👍 thanks, I hadn't seen that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like super calls need to explicitly specify their args now, so I added the
arg in
Call.prototype.updateLocationDataIfMissing.Also, the JS code hadn't updated, I guess due to the build failure, so re-run
bin/cake buildsolexer.jsandnodes.jsboth get updated. This fixes thetests.