Call synchronous fs methods using the Sync variants
#4340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c` functions without callbacks; but we always want the synchronous versions, so we should just call those in the first place
EsrefDurna
added a commit
to EsrefDurna/coffeescript
that referenced
this pull request
Nov 12, 2025
Call synchronous `fs` methods using the `Sync` variants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 7-nightly throws deprecation warnings when calling
fsnon-Syncfunctions without callbacks, for examplefs.close fdinstead offs.closeSync fd. We always want the synchronous versions, so we should just call the *Syncmethods in the first place.As far as I know this should be backward-compatible through ancient versions of Node, so I’m submitting this against
master. I couldn’t get Node 0.8.0 to run on my machine, but I tested this in both 0.12.17 and 6.9.0 and in each version the code built and the tests pass.