Move delete back to model.remove #2930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts part of jashkenas#2838 to prevent unexpected behavior in collection/model remove events.
|
👍 Seems prudent to me. Thanks @tgriesser! |
braddunbar
added a commit
that referenced
this pull request
Dec 19, 2013
Move delete back to model.remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @caseywebdev pointed out, part of the change in #2838 could result in unexpected behavior in the model/collection
removeevents, as was pointed out by a use case in #2929. Since this wasn't really a necessary change, it's probably best to keep it as is.