Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce jQuery dependencies in tests #2761

Merged
merged 2 commits into from
Sep 16, 2013

Conversation

akre54
Copy link
Collaborator

@akre54 akre54 commented Sep 16, 2013

I've been experimenting with working around Backbone's (light) jQuery dependency (see #237, scoliosis and others), and it'd be great if the tests had as light a requirement on jQuery-specific features as possible (no more than the library itself does).

  • Remove $(document).ready from tests in favor of scripts-at-the-bottom and an IIFE
  • Change a jQuery-specific selector p:has(a) to two separate tests

Should make it easier to test with Zepto, adapters for MooTools, d3 and other jQuery-like APIs.

@braddunbar
Copy link
Collaborator

Looks good. I like the simplification regardless. Thanks, as always, @akre54!

@braddunbar braddunbar merged commit 4107366 into jashkenas:master Sep 16, 2013
@akre54 akre54 deleted the no-more-domready branch November 27, 2013 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet