Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model.parse may no longer set the idAttribute #2755

Merged
merged 1 commit into from
Sep 12, 2013

Conversation

tgriesser
Copy link
Collaborator

Getting rid of the temp models, should also fix some other issues, this assumes the idAttribute exists directly on the object used to construct the model, no longer allowing model.parse to dynamically set this property.

Note that collection.parse may still be used to prep this data on a fetch.

jashkenas added a commit that referenced this pull request Sep 12, 2013
model.parse may no longer set the idAttribute
@jashkenas jashkenas merged commit cbbd944 into jashkenas:master Sep 12, 2013
@caseywebdev
Copy link
Collaborator

👍

@mateusmaso
Copy link

hey @tgriesser, I found that you can't get rid of the temp models in a situation that your collection model is a method (only if you want to set a idAttribute inside the function prototype, which is a terrible idea I think). In that case your pull was leaving behind objects that were already in the collection but you didn't check the existence of it.

@braddunbar
Copy link
Collaborator

@mateusmaso I would look into overriding _prepareModel for that functionality instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants