Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete listener when its events map is empty. #2724

Closed
wants to merge 3 commits into from
Closed

Delete listener when its events map is empty. #2724

wants to merge 3 commits into from

Conversation

henrahmagix
Copy link

Previously a listener only gets deleted based on parameters passed to
stopListening, whereas it should get deleted if it doesn't have any events in
its _events map.

Fixes #2619

Delete listener when its events map is empty.
15acdee 
Previously a listener only gets deleted based on parameters passed
to stopListening, whereas it should get deleted if it doesn't have
any events in its _events map.
@akre54
Copy link
Collaborator

akre54 commented Aug 17, 2013

Needs the callback fix from #2619 but otherwise LGTM 👍

@henrahmagix henrahmagix mentioned this pull request Aug 17, 2013
Closed
More explicitly set callback in stopListening if it's falsey.
0331dc6 
Previously callback was being changed without checking its value,
which would result in improper event unbinding.
@henrahmagix
Copy link
Author

@akre54 callback fix applied after conversation in #2619 =)

jashkenas added a commit that referenced this pull request Sep 11, 2013
@jashkenas
Test from #2724 for listener cleanup.
42370dd
@jashkenas
Copy link
Owner

Huh. I've added the test case from this PR, but it's currently passing for me. Either this change isn't needed, or a better test case is.

@jashkenas jashkenas closed this Sep 11, 2013
@caseywebdev
Copy link
Collaborator

@jashkenas it's because _listeners is now _listeningTo. In fact, all of the _listeners tests are now invalid.

@jashkenas jashkenas reopened this Sep 11, 2013
jashkenas added a commit that referenced this pull request Sep 11, 2013
@jashkenas
Fixing borked listeners test. #2724
22ab3ea
@jashkenas jashkenas closed this in c198270 Sep 11, 2013
@henrahmagix
Copy link
Author

👍

@jtward jtward mentioned this pull request Jul 28, 2014
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory leak in _listeners with #stopListening implementation
4 participants
@henrahmagix @akre54 @jashkenas @caseywebdev