-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for the View#template convention. #2716
Conversation
Brad, |
While not provided by the library, <b>template</b> is an oft-used | ||
convention. It is usually defined as a function that takes an optional | ||
data argument and returns an html string. In other words, it conforms to | ||
the api of Underscores |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HTML
, API
and Underscore's
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Thanks Casey!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Maybe this would be better as something that's folded into the documentation for At very least this should come after render in the docs. |
@wookiehangover Huh...I thought exactly the opposite. Currently, the docs for |
data argument and returns an HTML string. In other words, it conforms to | ||
the API of Underscore's | ||
<a href="http://underscorejs.org/#template"><b>template</b></a> function. | ||
While this convention is common, it's certainly not required and not used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'and not' could be 'nor'
Nice idea, but needs a bit of rewording. Should explain what |
Reworded above. Prose is not my strong suit so feel free to suggest other changes. :) |
Add docs for the View#template convention.
It was pointed out on the mailing list that there is no documentation for
View#template
, despite being a rather strong convention. Perhaps it's worth including, perhaps not. I'd love to hear some thoughts about it.