In tests, I tweaked model.parse(opt) to be model.parse(attrs) for descriptiveness #2304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking through the tests to get a better understanding of backbone. I figured the tests would be a great source of documentation for the granular aspects. :)
For the model parse() tests, I saw that the input arg was
obj
. I thoughtattrs
would be a bit more descriptive. This makes it align with the source. What do you guys think?In the end, this is a very microscopic change, but this is my first commit to open source, so I figured I'd try to see what happens! :)