Skip to content

Conversation

dillonforrest
Copy link
Contributor

I was looking through the tests to get a better understanding of backbone. I figured the tests would be a great source of documentation for the granular aspects. :)

For the model parse() tests, I saw that the input arg was obj. I thought attrs would be a bit more descriptive. This makes it align with the source. What do you guys think?

In the end, this is a very microscopic change, but this is my first commit to open source, so I figured I'd try to see what happens! :)

braddunbar added a commit that referenced this pull request Feb 21, 2013
In tests, I tweaked model.parse(opt) to be model.parse(attrs) for descriptiveness
@braddunbar braddunbar merged commit 11af9b4 into jashkenas:master Feb 21, 2013
@braddunbar
Copy link
Collaborator

Hi @dillonforrest, thanks for contributing! I agree that attrs is more descriptive. That argument is often called resp as well since it's generally a response object from the server. I may tweak it in that manner.

Also, congrats on your first commit! Hope to see you around again. :)

@dillonforrest
Copy link
Contributor Author

Thanks @braddunbar!! :) I'm hoping to find bigger ways to contribute next time!

@dillonforrest dillonforrest deleted the fix/descriptive-parse-tests branch February 22, 2013 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants