Lowercase books in docs #2219
Merged
Lowercase books in docs #2219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe @jashkenas' intent here was that |
|
Instances should always be lowercase 👍 |
|
If we're going to merge this, we should address the other upper case variables as well. |
|
+1 |
|
Cool... pretty sure I got them all. Wasn't sure about |
I think sticking to the lowercase instance rule is still best here, like you have it. |
|
Looks good to me. Thanks @tgriesser! |
This was referenced Mar 21, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The uppercased
Booksin the underscore example section makes it appear as though the underscore methods are static.