Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct CronBasedScheduledProcess Signatures #16

Closed
jas34 opened this issue Jul 8, 2021 · 0 comments · Fixed by #19
Closed

Correct CronBasedScheduledProcess Signatures #16

jas34 opened this issue Jul 8, 2021 · 0 comments · Fixed by #19
Assignees
@jas34
Labels
improvement Improvement in implementation

Comments

@jas34
Copy link
Owner

jas34 commented Jul 8, 2021

Currently CronBasedScheduledProcess<Job> is denoted by generic param. We should have fixed signature for CronBasedScheduledProcess having ScheduledProcess<Job> where Job = com.coreoz.wisp.Job
@jas34 jas34 self-assigned this Jul 8, 2021
@jas34 jas34 added the improvement Improvement in implementation label Jul 8, 2021
jas34 added a commit that referenced this issue Jul 11, 2021
@jas34
#15 fixed scheduled job cancellation problem in cluster environment.
54cac89 
#16 done required changes.
More test cases added.
jas34 added a commit that referenced this issue Jul 11, 2021
@jas34
#15, #16 removed useless TODO comment
ab0159c
@jas34 jas34 mentioned this issue Jul 11, 2021
Closed
@jas34 jas34 linked a pull request Jul 11, 2021 that will close this issue
Scheduled job not cancel issue #18
Closed
@jas34 jas34 mentioned this issue Jul 11, 2021
Merged
@jas34 jas34 linked a pull request Jul 11, 2021 that will close this issue
Scheduled job not cancel issue #19
Merged
@jas34 jas34 closed this as completed in #19 Jul 11, 2021
jas34 added a commit that referenced this issue Jul 11, 2021
@jas34
Scheduled job not cancel issue (#19)
1595edd 
* #15 fixed scheduled job cancellation problem in cluster environment.
#16 done required changes.
More test cases added.

* #15, #16 removed useless TODO comment

* updated readme

* updated readme

* updated readme

* excluded applicable packages from test code coverages.

* formatted pom.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jas34 jas34

Labels
improvement Improvement in implementation
Projects
None yet
Milestone
No milestone
1 participant
@jas34