Skip to content
This repository was archived by the owner on Mar 5, 2022. It is now read-only.

Automated test script and Travis CI integration #31

Merged
merged 3 commits into from
Feb 23, 2016
Merged

Conversation

zmwangx
Copy link
Collaborator

@zmwangx zmwangx commented Feb 23, 2016

Just to give you something to review. The automated test script is hopefully both reasonably robust and user friendly. Give it a spin:

./test

or

./test -q

which is quieter. Or read the brief help text first (./test -h).

Some initial builds on my fork can be found here: https://travis-ci.org/zmwangx/googler/builds. Unfortunately I spammed thousands of queries in the first build, and was subsequently blocked. (Although I've updated the script to only generate 100 — this number is customizable — queries.) There seems to be nothing I could do except to wait it out.

@jarun
Copy link
Owner

jarun commented Feb 23, 2016

All clear! (as far as I checked)

jarun added a commit that referenced this pull request Feb 23, 2016
Automated test script and Travis CI integration
@jarun jarun merged commit 4a32545 into jarun:master Feb 23, 2016
@zmwangx
Copy link
Collaborator Author

zmwangx commented Feb 23, 2016

Oops, I had a fixup commit right there which I thought I'd rebase after some discussions... I should have added a [WIP]. Would you mind if I rebase and force push to master? Not the best idea, but better than having a fixup commit that was meant to be rebased to begin with.

@zmwangx
Copy link
Collaborator Author

zmwangx commented Feb 23, 2016

Also, could you please set up https://travis-ci.org/jarun/googler?

@zmwangx
Copy link
Collaborator Author

zmwangx commented Feb 23, 2016

I've since pushed another (477af54) fix to this branch, an issue I discovered when I was reading the help I wrote myself. I probably need to read through the test script once more, because I wrote it at 2AM last night 😉

@zmwangx
Copy link
Collaborator Author

zmwangx commented Feb 23, 2016

And holy cow, the latest fixup commit (I forgot [ci skip] apparently) is all green on Travis! https://travis-ci.org/zmwangx/googler/builds/111285850.

@zmwangx
Copy link
Collaborator Author

zmwangx commented Feb 23, 2016

I have moved the discussion to a new PR #32. The comment above is not true: I made a newbie mistake (happens when coding late at night...) of modifying global variable in a pipeline, which resulted in update to exitcode not being reflected.

@jarun
Copy link
Owner

jarun commented Feb 23, 2016

@lock lock bot locked and limited conversation to collaborators Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants