This repository has been archived by the owner on Mar 5, 2022. It is now read-only.
Fix metadata extraction of YouTube results #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before:
$ googler --np gangnam style
1. PSY- Gangnam Style (Official Music Video) - YouTube
https://www.youtube.com/watch?v=CH1XGdu-hzQ
23 Oct 2012 - 5 min - Uploaded by DanceGangnamStyle50+ videos Play all Mix - PSY- Gangnam Style (Official Music Video)YouTube · Darci Lynne ...
After:
$ googler --np gangnam style
1. PSY- Gangnam Style (Official Music Video) - YouTube
https://www.youtube.com/watch?v=CH1XGdu-hzQ
23 Oct 2012, 5 min, Uploaded by DanceGangnamStyle
50+ videos Play all Mix - PSY- Gangnam Style (Official Music Video)YouTube · Darci Lynne ...
|
Awesome! |
|
Hope it doesn't cause any regression. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently noticed that metadata in YouTube results isn't parsed correctly. To add insult to injury, the semantically important
<br>tag is dropped amongst other semantically unimportant ones, causing metadata and abstract to be joined without a space in between.Before:
After:
This is a slightly risky change since metadata criterion changed from
.slpto.f(metadata in the traditional setting is always.f.slpin my experience). Not sure if there's regional variance.