Enable compilation on MacOS PowerPC #197
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes allow for Blink and Blinkenlights to be compiled for MacOS PowerPC hosts, tested on MacOS Tiger 10.4. Due to its legacy nature, the Tiger build was done with MacPorts GCC 14 and legacy-support-devel. Major changes include working around a missing F_DUPD_CLOEXEC macro with two fcntls; including sys/types.h before netinet/udp.h; adding detection for the __ppc__ macro for cpuid purposes; and ensuring feature flags are properly matched to ensure mkfifo does not turn on mkfifoat.
|
In fact, this patch fixes the build on any macOS below 10.7. |
|
@bjia56 Do you have a Cygwin environment handy to fix the build / headers issue? |
|
Not locally, but I can spin one up in a virtual environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow for Blink and Blinkenlights to be compiled for MacOS PowerPC hosts, tested on MacOS Tiger 10.4. Due to its legacy nature, the Tiger build was done with MacPorts GCC 14 and legacy-support-devel.
Major changes include working around a missing F_DUPD_CLOEXEC macro with two fcntls; including sys/types.h before netinet/udp.h; adding detection for the __ppc__ macro for cpuid purposes; and ensuring feature flags are properly matched to ensure mkfifo does not turn on mkfifoat.