Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort tv shows by date played #741

Merged

Conversation

Hjaelp
Copy link
Contributor

@Hjaelp Hjaelp commented Apr 29, 2024

For series content, Jellyfin uses "SeriesDatePlayed" to sort by last played rather than the current "DatePlayed".

Tested it, and I'm getting the same sort result in findroid and jellyfin with this change, but I'm not sure the best way to do this change. I was going to create a separate enum, but this is the only sort property that has has this issue.

@jarnedemeulemeester
Copy link
Owner

Damn, that's really dumb. Why isn't DatePlayed just the date played of a series instead of creating a separate value SeriesDatePlayed... Looks like something that was inherited from Emby back in the day. Or maybe I'm missing the reason.

IMO the ideal solution would be for Jellyfin to make DatePlayed the actual date played of a series.

But I suppose we can also implement a fix in the mean time.

Your solutions does not completely work. When Date Played is selected for a series library it is not visibly selected in the sort dialog. And also when selecting it for a series library and navigating to a movies library it does not sort the movies properly.
I have an other fix inspired by yours which I will push to this branch shortly.

@jarnedemeulemeester
Copy link
Owner

@Hjaelp please review and test my changes if they still work for you 🙂

@Hjaelp
Copy link
Contributor Author

Hjaelp commented Apr 30, 2024

Thank you, I completely forgot that the sort is saved. I'll test it on my phone and tablet today and Wednesday.

@Hjaelp
Copy link
Contributor Author

Hjaelp commented May 2, 2024

Yep, tested it for a bit and everything worked perfect.

@jarnedemeulemeester jarnedemeulemeester changed the title Fix wrong "Date Played" sort for TV shows fix: sort tv shows by date played May 2, 2024
@jarnedemeulemeester jarnedemeulemeester merged commit 9379e60 into jarnedemeulemeester:main May 2, 2024
2 checks passed
ghost pushed a commit to pruthvi-21/findroid that referenced this pull request Jul 22, 2024
* Fix wrong "Date Played" sort for TV shows

* fix: change sortby dateplayed to seriesdateplayed right before retrieving items

---------

Co-authored-by: Jarne Demeulemeester <jarnedemeulemeester@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants