Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing/hardcoded strings #415

Merged
merged 3 commits into from
Jun 23, 2023

Conversation

cd16b
Copy link
Contributor

@cd16b cd16b commented Jun 20, 2023

Related to #413
Remove hardcoded strings and add missing strings

Let me know if you find any other strings

@cd16b cd16b changed the title fix: add missing/hardcoded strings fix: missing/hardcoded strings Jun 20, 2023
@jarnedemeulemeester
Copy link
Owner

Ah damn I just fixed the hardcoded strings in #413.
Could you pull in the changes I have made on the main branch?
We can still merge the player control strings of course :)

@cd16b
Copy link
Contributor Author

cd16b commented Jun 21, 2023

Done

@jarnedemeulemeester jarnedemeulemeester merged commit ce1fe7e into jarnedemeulemeester:main Jun 23, 2023
@cd16b cd16b deleted the fix-strings branch June 27, 2023 08:47
ghost pushed a commit to pruthvi-21/findroid that referenced this pull request Jul 22, 2024
* fix: add missing/hardcoded strings

* Update strings.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants