Fixed OpenMPT not looping #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HumanGamer
force-pushed
the
openmpt_looping
branch
from
6761c26 to
b3e8e3f
Compare
HumanGamer
changed the title
|
I should note the original PR was to add support for looping via the set looping function. But I later realized that the implementation didn't work with Loop Points in some module files. So I looked into it and LibOpenMPT actually supports a looping option. It seems this was added after the fact and the default behaviour was changed. So I force pushed this new version instead, which comes as more of a fix to match the docs so that it will always loop, and not adding support for the Set Looping function. So I renamed the PR and rewrote the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs state that OpenMPT modules should always loop, however they don't and can't be set to loop. This PR fixes that.