Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return model to match default behaviour of eloquent #23

Merged
merged 1 commit into from
May 24, 2019

Conversation

Remo
Copy link
Contributor

@Remo Remo commented Nov 27, 2018

As mentioned here #22, I believe setAttribute should return the current object to match the default behaviour of eloquent:
https://github.com/laravel/framework/blob/5.7/src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php#L550-L587

@jarektkaczyk jarektkaczyk merged commit 45b55dd into jarektkaczyk:5.6 May 24, 2019
@Remo Remo deleted the fix-set-attribute branch May 24, 2019 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants