Add a unit test for testing nested relationships with soft deleted records. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the requested unit test as was requested in jarektkaczyk/eloquence#220. If you don't like the idea of filtering out deleted records inside of a
jointhen a way to exclude softly deleted records would be adding'where "posts"."deleted_at" is null ';at the end of the statement.I also thought it might make sense to have a sort of
withTrashedscope that would enable search across deleted records. Let me know your thoughts about it, I'll also be thinking about a better way to do it if it at least makes sense...