Update project #6
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thank's for this example repo !
I tested it and I want to update dependencies.
But I'm a newbie in Reason, so I'll try to explain the changes I made and I need reviews please.
bs-react-native related
Add
String()
to color and backgroundColor styles.reason-react related
I run the script to update ReasonReact from
0.4.2-to-0.5.0
https://github.com/chenglou/upgrade-reason-react
It updated
Style.(
to{ open Style;
, andReactEventRe.Mouse
toReactEvent.Mouse
and some other syntax changes (remove some brackets, add some commas, etc)Use the new Subscriptions helper in
ClientRoot
.react-native-web related
Froze
react
andreact-dom
to16.4.X
because it has breaking changes with16.5.X
Change global CSS and server style SSR from react-native-web doc.
Add
react-art
: it's noted as optional onreact-native-web
getting started documentation, but I don't find a way to do without it by default.Create a
<TextLink>
component using<Text>
fromreact-native-web
instead of ana
element. It's in JS becausebs-react-native
don't take into account specific props only available inreact-native-web
.I took exemple from this code : https://github.com/MoOx/moox.io/blob/2b7d26596e9da068b9fa95fe0f4190db8908a0be/src/components/TextLinkNative.js
And I ended up with 3 files, I don't know if it's ok or not.
Thank's