Fix getting false positives when using Cypress v5+ native retries #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmeikle
changed the title
|
Can we get that in please? |
Liu233w
added a commit
to Liu233w/acm-statistics
that referenced
this pull request
Nov 5, 2020
It cause image snapshot malfunctioning. The commit should be reverted after jaredpalmer/cypress-image-snapshot#155 being merged.
Liu233w
added a commit
to Liu233w/acm-statistics
that referenced
this pull request
Nov 5, 2020
It cause image snapshot malfunctioning. The commit should be reverted after jaredpalmer/cypress-image-snapshot#155 being merged.
|
Can you merge it please? It is very helpful |
|
Hey, I will be happy if this PR will be merged |
|
I hope it will be merged soon. very important fix |
|
Seems like this PR can hold great value, can you merge it, please? |
|
+1 |
|
Big, big, big, +1 👏 |
Open
This was referenced Dec 18, 2020
|
Please @jaredpalmer could you merge this? |
jaredpalmer
approved these changes
Jan 16, 2021
|
Any chance of an npm release based on this? Would be nice since it's a pretty big thing for Cypress v5 support. |
|
Can cut in a few min |
|
+1 |
|
Hey @jaredpalmer would you be able to publish this to npm please? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using native retries that come in Cypress v5+ real image failures are marked as passed on the retries.
This is because cypress names the snapshots as 'filename (attempt X).png (and there is no configuration option to change this)
The fix just removes the ' (attempt X)' suffix from the filename