Fix for false "internal error" message in Browser

[dpolivaev]

Hello,

the issue already described in jaredhanson/passport-google#3 unfortunately occurs in vanilla openid apps too. So if I run your example and enter a wrong URL in the login field like this

I get an error stack trace displayed in the browser.

The reason for this behavior is that the strategy interpretes a wrong URL as internal error although it can actually be entered by a user.
After applying the suggested fix the wrong input results in a redirect back to the login page which I think is a correct behavior.
Please check this issue, it is a show stopper.

Kind regards, Dimitry

[rajgitter]

if i change from self.error to self.fail, and if i provide a bad openid url passport is not redirecting to failureRedirect url.

[rwky]

@dpolivaev can you please make a PR against https://github.com/passport-next/passport-openid and it'll get looked into.